Delta Projects bid adapter: add new bid adapter#7564
Merged
FilipStamenkovic merged 3 commits intoprebid:masterfrom Oct 26, 2021
Merged
Delta Projects bid adapter: add new bid adapter#7564FilipStamenkovic merged 3 commits intoprebid:masterfrom
FilipStamenkovic merged 3 commits intoprebid:masterfrom
Conversation
FilipStamenkovic
suggested changes
Oct 13, 2021
Contributor
FilipStamenkovic
left a comment
FilipStamenkovic
left a comment
There was a problem hiding this comment.
Your tests are failing, take a look at the CircleCI output.
Also, please revert the changes you made on hello_world.html.
muuki88
reviewed
Oct 14, 2021
modules/deltaprojectsBidAdapter.js
Outdated
|
|
||
| // bidfloor | ||
| if (bid.params.floor) { | ||
| impression.bidfloor = bid.params.floor; |
Collaborator
There was a problem hiding this comment.
IIRC starting with prebid 5.x all adapters must support the floor price module. So you would need to enhance this logic and also check for a getFloor function.
Contributor
Author
|
Hi, @FilipStamenkovic and @muuki88, thanks for your reviews. We will make adjustments according to your comments as soon as possible. |
remove bidderParams which is not currently supported remove bid parameter floor remove unused function so linting is happy Remove unused params in tests use adservercurrency include .js to make linter happy again
FilipStamenkovic
approved these changes
Oct 26, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
* Delta Projects bid adapter: add new bid adapter * Delta Projects bid adapter: revert accidental change to hello_world.html * Remove unsupported functions by IE, add support for floor price remove bidderParams which is not currently supported remove bid parameter floor remove unused function so linting is happy Remove unused params in tests use adservercurrency include .js to make linter happy again Co-authored-by: Boris-Tang <boris.tang@deltaprojects.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: