Outbrain adapter: Support eids#7567
Merged
patmmccann merged 1 commit intoprebid:masterfrom Oct 25, 2021
Merged
Conversation
patmmccann
approved these changes
Oct 21, 2021
Collaborator
|
your doc says you only support liveramp but this passes all the eids. Can you align the two? |
osazos
approved these changes
Oct 22, 2021
Collaborator
osazos
left a comment
osazos
left a comment
There was a problem hiding this comment.
LGTM, except the documentation as mentioned by @patmmccann
Contributor
Author
|
Internally we only support liveramp at the moment but are planning to support more providers. The code passes all eids so that we won't have to change the adapter every time we start supporting a new provider. Is this not ok? |
Collaborator
|
This works, just please keep your doc current when you change this on the backend |
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds support for passing eids via the Outbrain adapter.