Smartx Bid Adapter: enable pbjs log for bid request & outstream player config adjustment#7701
Merged
ChrisHuie merged 58 commits intoprebid:masterfrom Nov 12, 2021
Merged
Conversation
…window before the outstream related functions
ChrisHuie
changed the title
ChrisHuie
approved these changes
Nov 12, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
…r config adjustment (prebid#7701) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix * Out-Stream render update to SmartPlay 5.2 * ESlint fix * ESlint fix * ESlint fix * adjust tests, fixes * ESlint * adjusted desired bitrate examples * added bid.meta.advertiserDomains support * bug fix for numeric elementID outstream render * fix renderer url * support for floors module * bugfixes to be openRTB 2.5 compliant * update internal renderer usage * remove unused outstream_function logic * bugfix outstream options for default outstream renderer configuration * [PREB-10] fix empty title not configurable * add pbjs version * testing with outstream 5.3.0 * pbjs version into content.ext * made visibilityThreshold configurable * adjust position of pbjs version Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv>
10 tasks
This was referenced Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
minor changes to get the used pbjs version with the bid request and made visibility threshold outstream feature configurable through the ad unit
Related docs PR: prebid/prebid.github.io#3403