prebid Server Bid Adapter: added ortb2Imp.instl support#8040
Closed
TheMediaGrid wants to merge 1 commit intoprebid:masterfrom
Closed
prebid Server Bid Adapter: added ortb2Imp.instl support#8040TheMediaGrid wants to merge 1 commit intoprebid:masterfrom
TheMediaGrid wants to merge 1 commit intoprebid:masterfrom
Conversation
patmmccann
added
the
needs 2nd review
patmmccann
changed the title
Collaborator
|
Is this useful? I thought PBS took the whole object already |
Collaborator
|
@TheMediaGrid thanks for your contribution! Could you review and comment on #8062 Will this solve your need? |
Collaborator
|
@TheMediaGrid your test coverage was added in #8159 ; thanks for raising this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
For testing instl field in s2s go adapters, we need to update Server-to-Server Testing module to make possible to sent instl field