Add DistroScale Bid Adapter#8221
Conversation
|
This pull request introduces 1 alert when merging 0136296 into 64bd041 - view on LGTM.com new alerts:
|
|
hey @duancg -- looks like your test fails with linting errors, could those be resolved? |
Clean up code style issues
|
Hi @ncolletti , thanks for pointing it out, we linted the code and now it should pass all tests. and Here is the latest commit 61f768b . Should I file a new pull request or this request should suffice? |
|
@duancg The adapter looks great, nice work. Only thing I noticed is duplicate data being sent in your bid requests between |
Thanks for your comment! Yes, the information is replicated intentionally in two places for compatibility with some backend servers. |
Type of change
Description of change
Adding a new DistroScale Bid Adapter.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
This change does not change any API nor documentation other than the one dedicated to DistroScale Bid Adapter.
Add DistroScale Bid Adapter prebid.github.io#3665
Other information