Consent management: update GDPR example#8525
Merged
patmmccann merged 1 commit intoprebid:masterfrom Jun 8, 2022
Merged
Conversation
1 task
|
This pull request fixes 2 alerts when merging 2345f04 into 2118146 - view on LGTM.com fixed alerts:
|
|
@dgirardi It's totally OK, the example looks nice too. Thanks! |
patmmccann
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
@giniyat202 I have taken the liberty of using the CMP setup from #6377 - reasoning that if it's OK to use it in e2e tests, it may be OK to use it in examples. Please confirm that this is appropriate.