Skip to content

Synacormedia bid adapter: add tmax to requests based upon provided timeouts#8526

Merged
patmmccann merged 1 commit intoprebid:masterfrom
imediabrands:CAPT-252
Jun 10, 2022
Merged

Synacormedia bid adapter: add tmax to requests based upon provided timeouts#8526
patmmccann merged 1 commit intoprebid:masterfrom
imediabrands:CAPT-252

Conversation

@ecammit
Copy link
Contributor

@ecammit ecammit commented Jun 6, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This adds a "tmax" value to the requests made to the Synacor Media adserver backend whose value reflects the timeout configured for the bid. This should reduce instances of prebid.js client requests timing out before the adserver backend responds.

Other information

There are no updates required to the bidder documentation.

@ecammit ecammit changed the title CAPT-252: Synacormedia bid adapter: add tmax to requests based upon provided timeouts Synacormedia bid adapter: add tmax to requests based upon provided timeouts Jun 6, 2022
@ChrisHuie ChrisHuie self-requested a review June 8, 2022 14:51
@ChrisHuie ChrisHuie self-assigned this Jun 8, 2022
@patmmccann patmmccann merged commit f2f87e7 into prebid:master Jun 10, 2022
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
…rovided timeouts. (prebid#8526)

Co-authored-by: Timothy M. Ace <tace@imds.tv>
ecammit pushed a commit to imediabrands/Prebid.js that referenced this pull request Jun 27, 2023
@ecammit ecammit mentioned this pull request Jun 27, 2023
9 tasks
ecammit pushed a commit to imediabrands/Prebid.js that referenced this pull request Jun 27, 2023
…name of synacormedia adapter to imds"

This reverts commit 6619ed9.
ChrisHuie pushed a commit that referenced this pull request Jul 20, 2023
* Backport of pull request #8526 that was missing from rename of synacormedia adapter to imds

* CAPT-787: Add gpp support to imds adapter.

* CAPT-787: Change src= to pbjs/x.y.z to be consistent with prebid-server format.

* CAPT-787: Add gppsid parameter to usersync to mirror the prebid-server instance

* Revert "Backport of pull request #8526 that was missing from rename of synacormedia adapter to imds"

This reverts commit 6619ed9.

* CAPT-787: imds adapter: Resolve "undefined" passed in gpp string for usersync

---------

Co-authored-by: Timothy M. Ace <tace@imds.tv>
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
* Backport of pull request prebid#8526 that was missing from rename of synacormedia adapter to imds

* CAPT-787: Add gpp support to imds adapter.

* CAPT-787: Change src= to pbjs/x.y.z to be consistent with prebid-server format.

* CAPT-787: Add gppsid parameter to usersync to mirror the prebid-server instance

* Revert "Backport of pull request prebid#8526 that was missing from rename of synacormedia adapter to imds"

This reverts commit 6619ed9.

* CAPT-787: imds adapter: Resolve "undefined" passed in gpp string for usersync

---------

Co-authored-by: Timothy M. Ace <tace@imds.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments