Cwire Bid Adapter: fix cwcreative parameter conversion#8544
Merged
ChrisHuie merged 3 commits intoprebid:masterfrom Jun 9, 2022
Merged
Cwire Bid Adapter: fix cwcreative parameter conversion#8544ChrisHuie merged 3 commits intoprebid:masterfrom
ChrisHuie merged 3 commits intoprebid:masterfrom
Conversation
ChrisHuie
approved these changes
Jun 9, 2022
ChrisHuie
changed the title
Contributor
Author
|
Thanks @ChrisHuie for the fast merge! Much appreciated! |
espen-j
added a commit
to c-wire/Prebid.js
that referenced
this pull request
Jul 5, 2022
ChrisHuie
pushed a commit
that referenced
this pull request
Jul 5, 2022
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* Remove Id from cwcreative variables * Change cwcreative from number to string as expected by the endpoint, update doc * Add tests covering cwcreative type
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
..
Description of change
When passing
cwcreativeas a query parameter the adapter wrongly converts it to a number, whereas our endpoint expects a string.Added unit tests to cover the change.