PBJS-ORTB conversion library by dgirardi · Pull Request #8738 · prebid/Prebid.js

dgirardi · 2022-07-25T21:39:36Z

Type of change

Feature

Description of change

This is an initial version of the pbjs-ortb conversion library proposal, an attempt to unify all ORTB-related request generation and response parsing.

The following adapters have been refactored to use the new library:

Prebid Server
openxOrtb
improvedigital (FYI @jbartek25)

Other information

Closes #8562
Closes #8665 (missing: documentation on new s2sConfig.ortbNative configuration)
Library documentation is included in libraries/ortbConverter/README.md

lgtm-com · 2022-07-26T19:57:10Z

This pull request introduces 2 alerts when merging f6ed3122eb0f5f97ab9cb6317b9b9bfbc88c6b5d into 90d1a18 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

dgirardi · 2022-09-28T19:46:05Z

Fixed tmax; source.ext.schain is now set to the schain that is used by the most bidders in the request.

Regarding id, JSON object property order is in general not defined I think. Firefox' network tab orders them alphabetically. Javascript objects do preserve insertion order, but I don't think it's worth having extra code for that.

bretg · 2022-10-07T15:17:35Z

@dgirardi - @musikele found one more gap -- pricegranularity.

PBS should receive ext.prebid.targeting.pricegranularity so it quantizes the hb_pb* targeting values appropriately.

dgirardi · 2022-10-07T15:37:46Z

@bretg, I don't know what that refers to - I don't see granularity in PBS requests generated from master. Is this a regression or a new requirement? What should be in that field exactly?

musikele

I've been using it while working in my adapter, and in general there are no stoppers. I left some comments regarding "how it works", speaking of how i understood it, and also some questions to the author.

musikele · 2022-10-17T10:27:28Z

libraries/ortbConverter/converter.js

+        const impContext = Object.assign({bidderRequest, reqContext: ctx.req}, defaultContext, context);
+        const result = buildImp(bidRequest, impContext);
+        if (result != null) {
+          if (result.hasOwnProperty('id')) {


mainly cosmetic. Instead of "if (...) else ..." you can go with:

if (!result.hasOwnProperty('id')) { logError('Converted ORTB imp does not specify an id, ignoring bid request', bidRequest, result); return; } // logic for old true case...

libraries/ortbConverter/converter.js

libraries/ortbConverter/README.md

libraries/pbsExtensions/processors/mediaType.js

libraries/ortbConverter/README.md

modules/priceFloors.js

musikele

LGTM

mmoschovas

Looks good from my end. Great work here!

* Automatically resolve libraries and their dependencies * Move AnalyticsAdapter under libraries * PBJS-ORTB conversion library * Update ortbConverter README * Improvements on request generation * refactor openxOrtbBidAdapter * Update README * Filter out imps that have no id * Fix nativeMapper logic * Prebid core: simplify native ORTB logic * Remove nativeMapper; do not mix ORTB request and response * fix lint * set bidRequest.nativeParams after ortb -> legacy conversion * Fix native trackers for native ortb responses (including Prebid Server) * Clean up native processors; add s2sConfig.ortbNative * Make ext.prebid.floors.enabled respect first party data * do not set placement for oustream video * Improvements * convert improvedigitalBidAdapter * Update openxOrtbBidAdapter * Improve video validation logic * Move skip validation back to improvedigital * Update README * Override (not merge) context.nativeRequest * Update improvedigital adapter * Address PR feedback on improvedigital * Fix tmax to s2sConfig.timeout for PBS adapter * PBS adapter: set source.ext.schain with the most commonly used schain * Remove dead code * Use auctionId for source.tid * Update package-lock * Set source.tid to auctionId * Update README * Update README * Update README

dgirardi added 6 commits June 22, 2022 13:03

Automatically resolve libraries and their dependencies

02cff6a

Move AnalyticsAdapter under libraries

9d869f0

Merge branch 'master' into improve-libraries

4f9526a

Merge branch 'master' into improve-libraries

a7352fb

Merge branch 'master' into improve-libraries

736d3c8

PBJS-ORTB conversion library

ce7d2d9

dgirardi force-pushed the pbjs-ortb-squash branch from fef5f18 to ce7d2d9 Compare July 25, 2022 21:55

patmmccann added the feature label Jul 26, 2022

Update ortbConverter README

4ff2bdb

Merge branch 'master' into pbjs-ortb-squash

df34289

dgirardi force-pushed the pbjs-ortb-squash branch from f6ed312 to df34289 Compare July 26, 2022 20:34

dgirardi added 7 commits July 26, 2022 15:12

Improvements on request generation

5125faf

refactor openxOrtbBidAdapter

412241a

Merge branch 'master' into pbjs-ortb-squash

82f821c

Update README

638356c

Filter out imps that have no id

0dc5539

Fix nativeMapper logic

ddde079

Prebid core: simplify native ORTB logic

641bb2f

dgirardi mentioned this pull request Jul 27, 2022

Prebid core: fix native trackers for Prebid Server; simplify native ORTB logic #8748

Merged

1 task

dgirardi added 4 commits July 27, 2022 08:56

Remove nativeMapper; do not mix ORTB request and response

4e01807

fix lint

4f62a8f

set bidRequest.nativeParams after ortb -> legacy conversion

904ba93

Merge branch 'native-ortb-simpl' into pbjs-ortb-squash

e624e01

dgirardi mentioned this pull request Jul 27, 2022

Prebid Server: native ad JS event tracker support #8665

Closed

dgirardi added 5 commits July 27, 2022 13:20

Fix native trackers for native ortb responses (including Prebid Server)

d9b3070

Merge branch 'native-ortb-simpl' into pbjs-ortb-squash

1d00441

Clean up native processors; add s2sConfig.ortbNative

0fabca8

Make ext.prebid.floors.enabled respect first party data

0684ead

do not set placement for oustream video

92b1762

dgirardi added 2 commits September 28, 2022 09:19

Merge branch 'master' into pbjs-ortb-squash

9af135b

PBS adapter: set source.ext.schain with the most commonly used schain

769109a

dgirardi added 2 commits September 28, 2022 14:33

Remove dead code

72e8f60

Use auctionId for source.tid

476467e

dgirardi mentioned this pull request Sep 29, 2022

PBJS: document ORTB conversion library prebid/prebid.github.io#4049

Merged

2 tasks

dgirardi added 2 commits September 29, 2022 10:04

Update package-lock

50e5ab1

Merge branch 'master' into pbjs-ortb-squash

3b8f8ee

dgirardi mentioned this pull request Oct 6, 2022

Multiple bid adapters: use auctionId for source.tid #9074

Merged

1 task

dgirardi added 2 commits October 6, 2022 11:52

Set source.tid to auctionId

f231be2

Merge branch 'master' into pbjs-ortb-squash

e35b045

dgirardi added 3 commits October 11, 2022 07:35

Update README

b13d473

Merge branch 'master' into pbjs-ortb-squash

c1f46f3

Merge branch 'master' into pbjs-ortb-squash

81dc763

musikele reviewed Oct 17, 2022

View reviewed changes

dgirardi added 4 commits October 17, 2022 11:05

Update README

55d4a10

Merge branch 'master' into pbjs-ortb-squash

5a60a08

Merge branch 'master' into pbjs-ortb-squash

30ec4ef

Merge branch 'master' into pbjs-ortb-squash

b32701c

musikele mentioned this pull request Oct 19, 2022

PulsePoint Bid Adapter: First party data #9114

Merged

1 task

Update README

f865224

musikele approved these changes Oct 21, 2022

View reviewed changes

mmoschovas approved these changes Oct 21, 2022

View reviewed changes

patmmccann merged commit 21712ca into prebid:master Oct 21, 2022

JulieLorin mentioned this pull request Dec 13, 2022

Prebid server adapter: consent information missing + conflict with site/app object #9333

Closed

ckbo3hrk mentioned this pull request May 16, 2023

Ortb Converter : add support for top level 'native' prop for PBS native admarkup #9959

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PBJS-ORTB conversion library#8738

PBJS-ORTB conversion library#8738
patmmccann merged 60 commits intoprebid:masterfrom
dgirardi:pbjs-ortb-squash

dgirardi commented Jul 25, 2022 •

edited

Loading

Uh oh!

lgtm-com bot commented Jul 26, 2022

Uh oh!

dgirardi commented Sep 28, 2022 •

edited

Loading

Uh oh!

bretg commented Oct 7, 2022

Uh oh!

dgirardi commented Oct 7, 2022

Uh oh!

musikele left a comment

Uh oh!

musikele Oct 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

musikele left a comment

Uh oh!

mmoschovas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Comments

Conversation

dgirardi commented Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

lgtm-com bot commented Jul 26, 2022

Uh oh!

dgirardi commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bretg commented Oct 7, 2022

Uh oh!

dgirardi commented Oct 7, 2022

Uh oh!

musikele left a comment

Choose a reason for hiding this comment

Uh oh!

musikele Oct 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

musikele left a comment

Choose a reason for hiding this comment

Uh oh!

mmoschovas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Comments

dgirardi commented Jul 25, 2022 •

edited

Loading

dgirardi commented Sep 28, 2022 •

edited

Loading