OpenX Analytics Adapter: adapter no longer offered, remove adapter#8795
Closed
bwschmidt wants to merge 1 commit intoprebid:masterfrom
Closed
OpenX Analytics Adapter: adapter no longer offered, remove adapter#8795bwschmidt wants to merge 1 commit intoprebid:masterfrom
bwschmidt wants to merge 1 commit intoprebid:masterfrom
Conversation
1 task
Contributor
Author
Collaborator
|
@bwschmidt removing adapters is a breaking change, but feel free to make it not call your endpoint (or do anything) and document that it has no function |
ChrisHuie
changed the title
Contributor
Author
|
@patmmccann makes sense, for prebid/prebid.github.io#3947 is that okay as is or should I just change the docs to say something like "OpenX has deprecated analytics" |
|
Docs PR: |
1 task
Contributor
Author
|
here is a new PR as requested #8828. Should this PR remain open for Prebid 8? |
Collaborator
|
Prebid 8 is a long time (at least a few months) away, let's close it for now, I've got it mentioned in the tracking issue |
Collaborator
|
I think docs okay as is
…On Mon, Aug 8, 2022 at 4:16 PM Brian Schmidt ***@***.***> wrote:
@patmmccann <https://github.com/patmmccann> makes sense, for
prebid/prebid.github.io#3947
<prebid/prebid.github.io#3947> is that okay as is
or should I just change the docs to say something like "OpenX has
deprecated analytics"
—
Reply to this email directly, view it on GitHub
<#8795 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z52A76SDOTGA47R4WDVYFTLRANCNFSM55XJ2NEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
OpenX no longer offers analytics, removing the adapter