Triplelift Bid Adapter: prioritize topmostLocation#9178
Merged
ChrisHuie merged 5 commits intoprebid:masterfrom Nov 1, 2022
Merged
Triplelift Bid Adapter: prioritize topmostLocation#9178ChrisHuie merged 5 commits intoprebid:masterfrom
ChrisHuie merged 5 commits intoprebid:masterfrom
Conversation
…tionB TL-32522: prioritize topmostLocation as referrer
ChrisHuie
approved these changes
Nov 1, 2022
1 task
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* prioritize topmostlocation * adds test for topmostlocation / referrer * cleanup * delete param after test
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* prioritize topmostlocation * adds test for topmostlocation / referrer * cleanup * delete param after test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We are running into similar issues as Kargo as it pertains to DSPs pointing out they are receiving URLs that are not consistent with the actual page of the article. This PR prioritizes
topmostLocationoverpagerefererInfo.Larger question: Should
refererInfo.pagebe prioritizing canonical URLs over the topmostLocation?Example: