Conversation
Remove this comment; Use adloader.loadScript function; use CONSTANTS
|
@AdBund Please add unit tests |
| ua: window.navigator.userAgent | ||
| }; | ||
| var param = Object.assign({}, bid.params, info); | ||
| param.sizes = JSON.stringify(param.sizes || bid.sizes); |
There was a problem hiding this comment.
I am getting bid back for size [[300,250]] but not for [300,250]. Please add support for the same.
There was a problem hiding this comment.
Has been modified, please review again
|
This is a what's wrong? @jaiminpanchal27
|
test/spec/adapters/adbund_spec.js
Outdated
| @@ -0,0 +1,102 @@ | |||
| import { expect } from 'chai'; | |||
| import Adapter from '../../../src/adapters/adbund'; | |||
| import adapterManager from 'src/adaptermanager'; | |||
There was a problem hiding this comment.
import of adaptermanager is causing the problem. Remove this line.
You can check https://github.com/prebid/Prebid.js/blob/master/test/spec/adapters/hiromedia_spec.js
|
Looks good. Thanks @AdBund |
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
|
Added adbund. md to dev-docs directory.Thanks |
…18.0 to aolgithub-master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
5 participants
Type of change
Description of change
Other information