Skip to content

Greenbids Analytics Adapter: create new analytics adapter for Greenbids#9690

Merged
patmmccann merged 3 commits intoprebid:masterfrom
greenbids:analytics-greenbids
Apr 4, 2023
Merged

Greenbids Analytics Adapter: create new analytics adapter for Greenbids#9690
patmmccann merged 3 commits intoprebid:masterfrom
greenbids:analytics-greenbids

Conversation

@jbogp
Copy link
Contributor

@jbogp jbogp commented Mar 20, 2023

  • New Analytics adapter

Description of change

Greenbids Analytics Adapter: create the new module

{
  provider: 'greenbids',
  options: {
    pbuid: "PBUID_FROM_GREENBIDS"
    sampling: 1.0
  }
}

@ChrisHuie
Copy link
Collaborator

@jbogp can you please pull in recent commits on master. A commit over the weekend limited our testing suite.

@jbogp jbogp force-pushed the analytics-greenbids branch from 1469ea1 to 8de4a61 Compare March 20, 2023 22:01
@jbogp
Copy link
Contributor Author

jbogp commented Mar 20, 2023

@jbogp can you please pull in recent commits on master. A commit over the weekend limited our testing suite.

Sure thing, PR updated @ChrisHuie.

@ChrisHuie ChrisHuie requested a review from jlquaccia March 28, 2023 18:30
@jbogp jbogp force-pushed the analytics-greenbids branch 4 times, most recently from 219f760 to fffd2c7 Compare April 3, 2023 18:09
@jbogp jbogp force-pushed the analytics-greenbids branch from fffd2c7 to 85d2759 Compare April 3, 2023 21:25
@jbogp
Copy link
Contributor Author

jbogp commented Apr 3, 2023

Reworked some aspects of this PR while waiting for the review. I forgot about the workflow approval, could you please trigger the rest of the CI again @ChrisHuie, so that @jlquaccia has the full picture when they start the review?
Thank you :)

Copy link
Collaborator

@jlquaccia jlquaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, changes lgtm

@patmmccann patmmccann merged commit 50c93ff into prebid:master Apr 4, 2023
hankyates-maven added a commit to themaven-net/Prebid.js that referenced this pull request Apr 28, 2023
* tag '7.44.0': (320 commits)
  Prebid 7.44.0 release
  Concert Bid Adapter: Enable support for additional userId's (prebid#9780)
  vidazoo Bid Adapter: update support of metaData (prebid#9749)
  Criteo Bid Adapter: Read GPP from ortb2 object (prebid#9775)
  OpenxOrtbAdapter: add back missing params support for coppa and video (prebid#9782)
  size map support (prebid#9772)
  Multiple bids in one request to Adrino Adserver (prebid#9742)
  Multiple modules: decouple GVL IDs from storage access control (prebid#9736)
  Update gumgumBidAdapter.js (prebid#9779)
  appnexus bid adapter - add gvlids to aliases (prebid#9777)
  Update undertoneBidAdapter.js (prebid#9778)
  PubMatic Bid Adapter: native 1.2 support (prebid#9701)
  Criteo ID Module: Add error callback for pixel sync call (prebid#9754)
  TTD Bid Adapter: add support for video.plcmt and imp.rwdd (prebid#9762)
  BrightcomSSP, Brightcom: remove options overide from buildRequests (prebid#9753)
  AIDEM Bid Adapter: extended app/site parameters on win notice  (prebid#9765)
  ZetaGlobalSsp Bid Adapter: provide tagid from params (prebid#9764)
  Craft Bid Adapter : update for imuIdSystem (prebid#9757)
  LocalStorage availability logging (prebid#9755)
  Greenbids Analytics Adapter: create new analytics adapter for Greenbids (prebid#9690)
  ...
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…ds (prebid#9690)

* Add Greenbids Analytics module

* fix doc

* rework payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments