Skip to content

Fixes for Centro adapter #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaiminpanchal27 merged 8 commits into from
Feb 28, 2017
Merged

Fixes for Centro adapter #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9edcb2b
Add centro adapter and tests for it.
Aug 23, 2016
fa9d30d
Merge remote-tracking branch 'upstream/master'
Oct 4, 2016
6f95de6
Merge remote-tracking branch 'upstream/master'
Nov 18, 2016
f1e2aed
Merge remote-tracking branch 'upstream/master'
Dec 21, 2016
9c54140
Merge remote-tracking branch 'upstream/master'
Feb 16, 2017
47c74aa
fix bug with different types of bid.sectionID and bid.unit from config
Feb 16, 2017
d0ca7a0
add query parameter adapter=prebid
Feb 16, 2017
8a092fe
update tests for centro adapter
Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/adapters/centro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@ var CentroAdapter = function CentroAdapter() {
utils.logError(LOG_ERROR_MESS.noUnit, bidderCode);
return;
}
var query = ['s=' + bid.unit];//,'url=www.abc15.com','sz=320x50'];
var query = ['s=' + bid.unit, 'adapter=prebid'];//,'url=www.abc15.com','sz=320x50'];
var isDev = bid.unit.toString() === '28136';

if (bid.page_url) {
query.push('url=' + encodeURIComponent(bid.page_url));
}
query.push('url=' + encodeURIComponent(bid.page_url || location.href));
//check size format
if (
size instanceof Array &&
Expand All @@ -55,7 +53,7 @@ var CentroAdapter = function CentroAdapter() {
query.push('sz=' + size.join('x'));
}
//make handler name for JSONP request
var handlerName = handlerPrefix + bid.unit + size.join('x');
var handlerName = handlerPrefix + bid.unit + size.join('x') + encodeURIComponent(placementCode);
query.push('callback=' + handlerName);

//maybe is needed add some random parameter to disable cache
Expand All @@ -77,7 +75,7 @@ var CentroAdapter = function CentroAdapter() {
var bidObject;
var bid = resp && resp.bid || resp;

if (bid && bid.adTag && bid.sectionID === unit) {
if (bid && bid.adTag && bid.sectionID && bid.sectionID.toString() === unit.toString()) {
bidObject = bidfactory.createBid(1);
bidObject.cpm = bid.value;
bidObject.ad = bid.adTag;
Expand Down
20 changes: 11 additions & 9 deletions test/spec/adapters/centro_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('centro adapter tests', function () {

var parsedBidUrl = urlParse(bidUrl1);
var parsedBidUrlQueryString = querystringify.parse(parsedBidUrl.query);
var generatedCallback = 'adCentroHandler_28136300x250';
var generatedCallback = 'adCentroHandler_28136300x250div-gpt-ad-12345-1';

expect(parsedBidUrl.hostname).to.equal('staging.brand-server.com');
expect(parsedBidUrl.pathname).to.equal('/hb');
Expand All @@ -92,13 +92,13 @@ describe('centro adapter tests', function () {

parsedBidUrl = urlParse(bidUrl2);
parsedBidUrlQueryString = querystringify.parse(parsedBidUrl.query);
generatedCallback = 'adCentroHandler_28137728x90';
generatedCallback = 'adCentroHandler_28137728x90div-gpt-ad-12345-2';

expect(parsedBidUrl.hostname).to.equal('t.brand-server.com');
expect(parsedBidUrl.pathname).to.equal('/hb');

expect(parsedBidUrlQueryString).to.have.property('s').and.to.equal('28137');
expect(parsedBidUrlQueryString).to.not.have.property('url');
expect(parsedBidUrlQueryString).to.have.property('url').and.to.equal(location.href);
expect(parsedBidUrlQueryString).to.have.property('sz').and.to.equal('728x90');
expect(parsedBidUrlQueryString).to.have.property('callback').and.to.equal(generatedCallback);
});
Expand Down Expand Up @@ -158,8 +158,10 @@ describe('centro adapter tests', function () {

adapter().callBids(params);

expect(window['adCentroHandler_28136300x250']).to.exist.and.to.be.a('function');
expect(window['adCentroHandler_111111728x90']).to.exist.and.to.be.a('function');
expect(window['adCentroHandler_28136300x250%2F19968336%2Fheader-bid-tag-0'])
.to.exist.and.to.be.a('function');
expect(window['adCentroHandler_111111728x90%2F19968336%2Fheader-bid-tag-1'])
.to.exist.and.to.be.a('function');
});

it('bidmanager.addBidResponse should be called with correct arguments', function () {
Expand Down Expand Up @@ -189,10 +191,10 @@ describe('centro adapter tests', function () {
var response3 = {"adTag":"","height":0,"value":0,"width":0,"sectionID":222222};
var response4 = '';

window['adCentroHandler_28136300x250'](response);
window['adCentroHandler_111111728x90'](response2);
window['adCentroHandler_222222728x90'](response3);
window['adCentroHandler_333333728x90'](response4);
window['adCentroHandler_28136300x250%2F19968336%2Fheader-bid-tag-0'](response);
window['adCentroHandler_111111728x90%2F19968336%2Fheader-bid-tag-1'](response2);
window['adCentroHandler_222222728x90%2F19968336%2Fheader-bid-tag-2'](response3);
window['adCentroHandler_333333728x90%2F19968336%2Fheader-bid-tag-3'](response4);

var bidPlacementCode1 = stubAddBidResponse.getCall(0).args[0];
var bidObject1 = stubAddBidResponse.getCall(0).args[1];
Expand Down