Skip to content

Comments

Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros#2371

Merged
SerhiiNahornyi merged 5 commits intoprebid:masterfrom
imediabrands:master
Jul 11, 2023
Merged

Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros#2371
SerhiiNahornyi merged 5 commits intoprebid:masterfrom
imediabrands:master

Conversation

@ecammit
Copy link
Contributor

@ecammit ecammit commented May 19, 2023

Synacormedia: Renames to "imds" and updates the endpoint configurations to match the latest. (see: prebid/prebid.github.io#4237)

  • The endpoint config now mirrors the golang prebid-server
  • Imds uses a single endpoint hostname instead of a dynamic hostname, for efficiency of open connections (see: PBS2.0: bidders with dynamic hosts prebid-server#2612)
  • Imds uses https to allow HTTP/2 negotiation
  • Marks synacormedia as a deprecated alias for later removal using the deprecated-names functionality.

Core: Fixes deprecated-names feature to correctly evaluate bidder names from request.imp[].ext.prebid.bidder.* instead of request.imp[].ext.*.

No other bidder seems to be using deprecated-names, so the bug has gone un-noticed since the original pull request (#169) was merged. Upon fixing this, I now receive the expected value in the response:

  "ext": {
    "errors": {
      "synacormedia": [
        {
          "code": 2,
          "message": "synacormedia has been deprecated and is no longer available. Use imds instead."
        }
      ]
    },

If you would like this bug fix split into a separate pull request, I can do that.

Timothy M. Ace added 2 commits May 19, 2023 10:04
…rks as a deprecated alias for later removal.

Core: Fixes deprecated-names feature to correctly evaluate bidder names from request.imp[].ext.prebid.bidder.* instead of request.imp[].ext.*.
@ecammit ecammit changed the title Synacormedia: Renames to "imds" Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros Jun 27, 2023
Comment on lines 99 to 100
String accountId = URLEncoder.encode(firstExtImp.getSeatId(), StandardCharsets.UTF_8);
String sourceId = URLEncoder.encode(prebidVersion, StandardCharsets.UTF_8);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, use final keyword everywhere where variable is not reassigned. Also, please, check for similar occurences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

…sing version as string rather than object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants