Skip to content

Conversation

@ShayanK16GumGum
Copy link
Contributor

@ShayanK16GumGum ShayanK16GumGum commented Apr 16, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested a review from CTMBNara April 22, 2025 09:45
@CTMBNara CTMBNara changed the title GumGum: Update Prebid Server Adapter (Java) to collect the ad unit name for reporting. GumGum: Collect the ad unit name for reporting Apr 23, 2025
@ShayanK16GumGum
Copy link
Contributor Author

Thank you for the review, I am looking into the comments.

@osulzhenko
Copy link
Collaborator

@ShayanK16GumGum any updates on this one?

@ShayanK16GumGum
Copy link
Contributor Author

The code changes are done, will push. @osulzhenko

@osulzhenko osulzhenko requested a review from CTMBNara May 12, 2025 08:27
@osulzhenko
Copy link
Collaborator

@ShayanK16GumGum

[INFO] Starting audit...
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:85:16: Variable 'requestBody' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:86:20: Variable 'modifiedRequest' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:94:17: There is more than 1 empty line after this line. [EmptyLineSeparator]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:100:20: Variable 'extImp' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:103:13: Variable 'imp' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:109:20: Variable 'bidRequest' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:116:47: Variable 'result' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:123:16: Variable 'requestBody' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:124:20: Variable 'modifiedRequest' should be declared final. [FinalLocalVariable]
Error:  /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java:128:13: Variable 'modifiedImp' should be declared final. [FinalLocalVariable]
Audit done.

@ShayanK16GumGum
Copy link
Contributor Author

@osulzhenko looking into it and fixing.

@osulzhenko
Copy link
Collaborator

@ShayanK16GumGum any updates on this one?

@ShayanK16GumGum
Copy link
Contributor Author

@osulzhenko I have pushed the changes. Please have a look.
Screenshot 2025-06-02 at 11 32 47 AM

@ShayanK16GumGum
Copy link
Contributor Author

ShayanK16GumGum commented Jun 10, 2025

Hi @CTMBNara, I've pushed the changes. I had missed the review comments but have seen them now. Please take a look.
Screenshot 2025-06-10 at 12 47 53 PM

@AntoxaAntoxic AntoxaAntoxic linked an issue Jun 27, 2025 that may be closed by this pull request
@CTMBNara CTMBNara merged commit d390d05 into prebid:master Jul 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: GumGum: Collect ad unit name for reporting

3 participants