Skip to content

Conversation

@AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic requested a review from CTMBNara May 26, 2025 13:26
@AntoxaAntoxic AntoxaAntoxic self-assigned this May 26, 2025
@AntoxaAntoxic AntoxaAntoxic linked an issue May 26, 2025 that may be closed by this pull request
@osulzhenko osulzhenko requested a review from CTMBNara June 9, 2025 11:38
@osulzhenko osulzhenko added blocked and removed blocked labels Jul 4, 2025
@osulzhenko osulzhenko requested a review from And1sS July 18, 2025 07:38
@CTMBNara CTMBNara merged commit 7e97ae7 into master Jul 29, 2025
8 checks passed
@CTMBNara CTMBNara deleted the madsense-bidder branch July 29, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: MadSense

4 participants