Tests: Bidder Usersync Skipwhen Config#4028
Merged
osulzhenko merged 4 commits intousersync-skipwhenfrom Jun 20, 2025
Merged
Conversation
marki1an
requested changes
Jun 19, 2025
| private static final Map<String, String> GENERIC_WITH_SKIP_CONFIG = [ | ||
| "adapters.${GENERIC.value}.meta-info.vendor-id" : GENERIC_VENDOR_ID as String, | ||
| "adapters.${GENERIC.value}.usersync.${USER_SYNC_TYPE.value}.url" : "$networkServiceContainer.rootUri/generic-usersync&redir={{redirect_url}}".toString(), | ||
| "adapters.${GENERIC.value}.usersync.skipwhen.gdpr" : 'true', |
Collaborator
There was a problem hiding this comment.
What about the case when gdpr: false?
| given: "Default CookieSyncRequest with gdpr config" | ||
| def cookieSyncRequest = CookieSyncRequest.defaultCookieSyncRequest.tap { | ||
| it.gppSid = TCF_EU_V2.intValue | ||
| it.gpp = null |
Collaborator
There was a problem hiding this comment.
gpp by default null
Same for other
| def "PBS should emit proper error message when alias request contain gdpr config and global skip gdpr config for adapter"() { | ||
| given: "Default CookieSyncRequest with gdpr config" | ||
| def cookieSyncRequest = CookieSyncRequest.defaultCookieSyncRequest.tap { | ||
| it.bidders = [BidderName.ALIAS] |
Collaborator
There was a problem hiding this comment.
- Can be just
ALIAS - Add config for
ALIAS, since for now it's unsupported bidder - Should be
response.getBidderUserSync(ALIAS)
src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy
Show resolved
Hide resolved
| assert HttpUtil.findUrlParameterValue(bidderStatus.userSync?.url, "gpp") == "" | ||
| assert HttpUtil.findUrlParameterValue(bidderStatus.userSync?.url, "gpp_sid") == gppSid.value | ||
|
|
||
| and: "Shouldn't contains any error" |
Collaborator
There was a problem hiding this comment.
"Response shouldn't contains any error""
src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy
Show resolved
Hide resolved
marki1an
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check