Merged
Conversation
SyntaxNode
reviewed
Sep 17, 2021
SyntaxNode
reviewed
Sep 20, 2021
Contributor
SyntaxNode
left a comment
SyntaxNode
left a comment
There was a problem hiding this comment.
Thank you for the quick update from my feedback. In this pass I'm asking for improved defensive programming (don't ignore errors) and an increase in json test coverage.
|
Related docs PR: prebid/prebid.github.io#3273 |
SyntaxNode
reviewed
Sep 28, 2021
SyntaxNode
reviewed
Sep 29, 2021
Contributor
SyntaxNode
left a comment
SyntaxNode
left a comment
There was a problem hiding this comment.
Looks good. Just a few more test comments. I think you'll need to add a new http_204.json test case and for the headers you can expand the existing headers.json IMHO.
SyntaxNode
reviewed
Oct 4, 2021
Contributor
SyntaxNode
left a comment
SyntaxNode
left a comment
There was a problem hiding this comment.
Looks good to me now, except for the small marsmedia comment. Thank you for making the requested changes and strengthening the test coverage. A second reviewer will take a look soon.
SyntaxNode
approved these changes
Oct 5, 2021
jizeyopera
pushed a commit
to operaads/prebid-server
that referenced
this pull request
Oct 13, 2021
Co-authored-by: Thomas De Stefano <thomas.destefano@impactify.io>
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
Co-authored-by: Thomas De Stefano <thomas.destefano@impactify.io>
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Co-authored-by: Thomas De Stefano <thomas.destefano@impactify.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impactify PBS Adapter.
Docs PR : prebid/prebid.github.io#3273