YIELDONE docs - add media_types#1016
Merged
bretg merged 2 commits intoprebid:masterfrom Nov 9, 2018
kusapan:master
Merged
Conversation
4 tasks
kusapan
changed the title
bretg
suggested changes
Oct 26, 2018
dev-docs/bidders/yieldone.md
Outdated
| | Name | Scope | Description | Example | Type | | ||
| |---------------|----------|------------------|---------|----------| | ||
| | `placementId` | required | The placement ID | | `string` | | ||
| | `placementId` | required | The placement ID | `36891` | `string` | |
Contributor
There was a problem hiding this comment.
If placementId is a string, please put it in quotes
Contributor
Author
There was a problem hiding this comment.
we fixed error. please check it.
bretg
approved these changes
Oct 29, 2018
bretg
added
LGTM
not merged yet
Pending PBJS Release
and removed
needs work
not merged yet
labels
Contributor
|
released with 1.31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to add media_types to YIELDONE docs.
This is the code: prebid/Prebid.js#3227