Synacormedia bid adapter updates:#1335
Merged
bretg merged 2 commits intoprebid:masterfrom Jul 25, 2019
Merged
Conversation
- Added more video parameters - Added video example - Fixed table so that it renders correctly
amuraco
force-pushed
the
synacormedia-may-updates
branch
from
e603afa to
ea535e8
Compare
bretg
suggested changes
Jun 4, 2019
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Please add 'scope' as the 2nd column to the video param table
Contributor
Author
|
I have pushed a commit with the requested changes:
|
bretg
approved these changes
Jun 10, 2019
Contributor
|
@bretg Any ETA for this PR to get merged? |
Contributor
|
Hi Team, |
Contributor
|
sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to PR: prebid/Prebid.js#3885