Skip to content

Comments

Documentation for pbjs.getUserIds method in User Id module#1361

Merged
bretg merged 4 commits intoprebid:masterfrom
pm-harshad-mane:getUserId
Jul 18, 2019
Merged

Documentation for pbjs.getUserIds method in User Id module#1361
bretg merged 4 commits intoprebid:masterfrom
pm-harshad-mane:getUserId

Conversation

@pm-harshad-mane
Copy link
Contributor

Documentation for pbjs.getUserIds method in User Id module

@pm-harshad-mane
Copy link
Contributor Author

Related PR: prebid/Prebid.js#3889

@pm-harshad-mane
Copy link
Contributor Author

Hello @bretg ,
Could you please review this?

@bretg
Copy link
Contributor

bretg commented Jun 25, 2019

@pm-harshad-mane - this doesn't follow our standard, which is that module-supplied functions are documented in the module.md file. I'll adjust.

@bretg
Copy link
Contributor

bretg commented Jun 25, 2019

Refined your PR just a bit -- thanks. This is just waiting on the code PR now.

@pm-harshad-mane
Copy link
Contributor Author

Thank you @bretg

@bretg
Copy link
Contributor

bretg commented Jul 18, 2019

released with 2.24

@bretg bretg merged commit 27decf6 into prebid:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants