Update adastamedia.md by Adasta2019 · Pull Request #1501 · prebid/prebid.github.io

Adasta2019 · 2019-09-19T08:30:10Z

Adasta Media is an aliased bidder for AppNexus.
Adasta Media no longer relies on Gamoshi for publication in Prebid. This new one replaces the existing one in your listings.

Adasta Media is an aliased bidder for AppNexus. Adasta Media no longer relies on Gamoshi for publication in Prebid. This new one replaces the existing one in your listings.

bretg

There are several problems with this request:

I don't see adasta listed as an alias in the AppNexus bid adapter or a PR to make that happen
The gamoshi adapter still refers to adastaMedia. If you're switching to AppNexus, you may want to move that alias as well.
Your existing users that refer to adastaMedia will no longer have any documentation.

I would recommend that you consider instead leaving the 'adastaMedia' documentation, perhaps with a note that encourages users to move to the new 'adasta' alias. Then add a new 'adasta.md' file with the placement ID parameter.

Adasta2019 · 2019-09-23T08:18:49Z

Hi Bretg, thankyou for your reply, this is the first time we use Git Hub and the procedure to follow is not very clear. At the moment there is no user using our adapter published via Gamoshi. For this reason we want to reuse the alias chosen with Gamoshi. Can I ask for more information regarding points 1 and 2 of your email? What should I do to be listed as an Appnexus alias? What is a PR? To be removed from the Gamoshi aliases and appear among those of Appnexus can I proceed independently or should I ask Gamoshi and Appnxus to do so? Thankyou, Imma Il 20/09/19 23:21, bretg ha scritto:

***@***.**** requested changes on this pull request. There are several problems with this request: 1. I don't see adasta listed as an alias in the AppNexus bid adapter or a PR to make that happen 2. The gamoshi adapter still refers to adastaMedia. If you're switching to AppNexus, you may want to move that alias as well. 3. Your existing users that refer to adastaMedia will no longer have any documentation. I would recommend that you consider instead leaving the 'adastaMedia' documentation, perhaps with a note that encourages users to move to the new 'adasta' alias. Then add a new 'adasta.md' file with the placement ID parameter. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1501?email_source=notifications&email_token=ANHVD4KPBHC56JEN3UN3JR3QKU5GJA5CNFSM4IYIBTWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFPHFJY#pullrequestreview-291402407>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANHVD4KM64S2Q4B5WQXNNGTQKU5GJANCNFSM4IYIBTWA>.

-- firma email *Imma Califano* *Web developer* *Phon*e +39 02 98650127 *Mobile* +39 329 8430147 *Skype* imma.califano Via Pastrengo 14 - 20159 Milano This message and any attachment are confidential and transmitted for the exclusive use of the intended recipient. It is prohibited for anyone other than the recipient to read, copy, duplicate and/or disclose the content to any third-person. Should you receive this message by mistake, please delete it and contact the sender by return e-mail. The contents expressed in this mail reflect the opinion of the sender, not necessarily that of the company.

bretg · 2019-09-24T19:26:42Z

If no one's using the adastaMedia alias, that's good - I'd say you should submit a PR to remove it from the gamoshi bid adapter.

But I don't think it's right to just add yourself as an alias to AppNexus -- once you've cleared it with them at a business level to host you as an alias, you can submit a PR against their adapter to add the alias, and we'll have an AppNexus person review it.

So this docs PR will be fine once there's a code PR with the alias. Thanks.

Adasta2019 · 2019-09-26T08:17:09Z

Hi Bretg,
I learned from Appnexus that we received their approval. What should I do now exactly in order to proceed quickly?
Thanks,
Imma

Adasta2019 · 2019-09-30T08:24:37Z

dev-docs/bidders/adastaMedia.md

-media_types: banner, video
-aliasCode: gamoshi
+biddercode: adasta
+aliasCode : appnexus


We have received authorization from Appnexus

Adasta2019 · 2019-09-30T08:25:06Z

dev-docs/bidders/adastaMedia.md

 hide: true
-biddercode: adastaMedia
-media_types: banner, video
-aliasCode: gamoshi


we have stopped any contract with Gamoshi

Adasta2019 · 2019-10-01T13:58:33Z

Hi bretg,
Just wanted to let you know that I have requested gamoshi to remove the adastaMedia alias from their bid adapter. It is bank holiday in Tel Aviv today and they have promised me they will do it tomorrow. From what I understood this should be the first step.
I also talked with Appnexus representative in Italy last week about the opportunity to host Adasta as an alias and then we received the green light from them.
Now we basically are stuck in the middle because we did not understand where we have to submit the PR from. Can you please, help us out on that?

bretg · 2019-10-01T14:11:08Z

@mkendall07 - what's the process for a partner like Adasta to add an alias to your adapter?

mkendall07 · 2019-10-01T14:28:54Z

@Adasta2019
You need to add your alias to this line of the AppNexus bid adapter:
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L44
Please open a pull request for that and we can review and approve. Thanks

Adasta2019 · 2019-10-01T16:18:16Z

Alias added and pull request opened. Looking forward to getting your approval. Thanks! Da: Matt Kendall <notifications@github.com> Risposta: "prebid/prebid.github.io" <reply@reply.github.com> Data: martedì 1 ottobre 2019 16:28 A: "prebid/prebid.github.io" <prebid.github.io@noreply.github.com> Cc: Adasta Media <supporto@adasta.it>, Mention <mention@noreply.github.com> Oggetto: Re: [prebid/prebid.github.io] Update adastamedia.md (#1501) @Adasta2019<https://github.com/Adasta2019> You need to add your alias to this line of the AppNexus bid adapter: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L44 Please open a pull request for that and we can review and approve. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1501?email_source=notifications&email_token=ANHVD4KZYRHRAORI6U22NBTQMNNCRA5CNFSM4IYIBTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABO53I#issuecomment-537063149>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANHVD4NH2NQZZGTHDJPWFSLQMNNCRANCNFSM4IYIBTWA>.

Adasta2019 · 2019-10-02T14:15:14Z

Just wanted to know if the approval has been obtained.
I spoke to gamoshi again today and they told me that they are taking care of my removal request.

Adasta2019 · 2019-10-03T06:45:26Z

@Adasta2019
You need to add your alias to this line of the AppNexus bid adapter:
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L44
Please open a pull request for that and we can review and approve. Thanks

@mkendall07 at this url prebid/Prebid.js#4251 you can find our modification. Can you proceed with validation and approval of the change?

Adasta2019 · 2019-10-04T08:09:38Z

@bretg - I can now see that adasta is an alias of appnexus and no longer alias of gamoshi. Can you please merge this branch as requested or do you have any other check to make?

bretg · 2019-10-04T11:58:15Z

It will be merged once Prebid.js 2.35 has been released

Adasta2019 · 2019-10-04T13:08:42Z

@bretg - Do you know if there is an ETA for that?

bretg · 2019-10-04T13:48:26Z

Prebid.js deploys are generally on Tuesdays

Adasta2019 · 2019-10-09T10:56:30Z

Prebid.js 2.35 is out now but you can still find gamoshi's code for Adasta. If you look at appnexus adapter code you can see Adasta among the aliases. Can you please let me know if something got wrong during the last deploy?
You can check it out also here - http://prebid.org/dev-docs/bidders.html#adastaMedia

bretg · 2019-10-09T13:43:47Z

Merged. Please confirm. I see the new adasta on http://prebid.org/download.html and http://prebid.org/dev-docs/bidders.html#adastaMedia

Adasta2019 · 2019-10-09T14:38:33Z

It is now confirmed. I can see everything updated.
May I ask if it is possible remove the following text 'Adasta Media is an aliased bidder for AppNexus' from http://prebid.org/dev-docs/bidders.html#adastaMedia ?

bretg · 2019-10-09T20:30:53Z

Sure it's possible - go ahead and open a new PR to remove the text from your file.

Adasta2019 · 2019-11-25T13:49:10Z

I resume this conversation because we have noticed that we are not listed any longer in the download section of Prebid.js as Adasta Media.
Can you please explain why this happened?

bretg · 2019-11-25T15:01:43Z

Sorry - fixed. There was a mixup between conflicting PRs. You're back on the download page.

Adasta2019 · 2019-11-25T15:24:48Z

Many thanks bretg!

Update adastamedia.md

25febf2

Adasta Media is an aliased bidder for AppNexus. Adasta Media no longer relies on Gamoshi for publication in Prebid. This new one replaces the existing one in your listings.

bretg suggested changes Sep 20, 2019

View reviewed changes

bretg added the needs work label Sep 20, 2019

Adasta2019 requested a review from bretg September 24, 2019 09:52

Adasta2019 commented Sep 30, 2019

View reviewed changes

bretg mentioned this pull request Oct 2, 2019

Removed AdastaMadia from alias prebid/Prebid.js#4255

Merged

10 tasks

bretg approved these changes Oct 4, 2019

View reviewed changes

bretg mentioned this pull request Oct 4, 2019

Update appnexusBidAdapter.js, added adastaMedia as alias prebid/Prebid.js#4251

Merged

10 tasks

bretg added LGTM Pending PBJS Release and removed needs work labels Oct 4, 2019

bretg removed the Pending PBJS Release label Oct 9, 2019

bretg merged commit b9ab08d into prebid:master Oct 9, 2019

Conversation

Adasta2019 commented Sep 19, 2019

Uh oh!

bretg left a comment

Choose a reason for hiding this comment

Uh oh!

Adasta2019 commented Sep 23, 2019 via email

Uh oh!

bretg commented Sep 24, 2019

Uh oh!

Adasta2019 commented Sep 26, 2019

Uh oh!

Adasta2019 Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

Adasta2019 Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

Adasta2019 commented Oct 1, 2019

Uh oh!

bretg commented Oct 1, 2019

Uh oh!

mkendall07 commented Oct 1, 2019

Uh oh!

Adasta2019 commented Oct 1, 2019 via email

Uh oh!

Adasta2019 commented Oct 2, 2019

Uh oh!

Adasta2019 commented Oct 3, 2019

Uh oh!

Adasta2019 commented Oct 4, 2019

Uh oh!

bretg commented Oct 4, 2019

Uh oh!

Adasta2019 commented Oct 4, 2019

Uh oh!

bretg commented Oct 4, 2019

Uh oh!

Adasta2019 commented Oct 9, 2019

Uh oh!

bretg commented Oct 9, 2019

Uh oh!

Adasta2019 commented Oct 9, 2019

Uh oh!

bretg commented Oct 9, 2019

Uh oh!

Adasta2019 commented Nov 25, 2019

Uh oh!

bretg commented Nov 25, 2019

Uh oh!

Adasta2019 commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments