Skip to content

Fix bidder docs support for userid module#1897

Merged
bretg merged 6 commits intoprebid:masterfrom
smenzer-forks:fix-bidder-docs-support-for-userid-module
Apr 2, 2020
Merged

Fix bidder docs support for userid module#1897
bretg merged 6 commits intoprebid:masterfrom
smenzer-forks:fix-bidder-docs-support-for-userid-module

Conversation

@smenzer
Copy link
Collaborator

@smenzer smenzer commented Mar 31, 2020

Many of the bid adapters' documentation did not properly list the userId submodules that they listen to in their adapter code.

This PR is to update each adapter's docs that are clearly listening to one or more userId submodules in their adapter code. Bid adapters can listen to providers via a whitelist of ID providers that are clearly called out in the code, or by grabbing the entire userIds or userIdAsEids array and adding them to their ad request payload.

ID providers are listen in alphabetical order, just like in the userId documentation.

@smenzer
Copy link
Collaborator Author

smenzer commented Apr 1, 2020

looks like OpenX put in a PR to add their updated user ID modules here #1875. Mine is a duplicate of theirs, technically, but keeps the ordering and naming consistent with everyone else, so I'd suggest we keep mine (if merged) and drop their PR.

@bretg bretg merged commit f21d71f into prebid:master Apr 2, 2020
@smenzer smenzer deleted the fix-bidder-docs-support-for-userid-module branch April 8, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments