Fix bidder docs support for userid module#1897
Merged
bretg merged 6 commits intoprebid:masterfrom Apr 2, 2020
Merged
Conversation
Collaborator
Author
|
looks like OpenX put in a PR to add their updated user ID modules here #1875. Mine is a duplicate of theirs, technically, but keeps the ordering and naming consistent with everyone else, so I'd suggest we keep mine (if merged) and drop their PR. |
bretg
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the bid adapters' documentation did not properly list the userId submodules that they listen to in their adapter code.
This PR is to update each adapter's docs that are clearly listening to one or more userId submodules in their adapter code. Bid adapters can listen to providers via a whitelist of ID providers that are clearly called out in the code, or by grabbing the entire
userIdsoruserIdAsEidsarray and adding them to their ad request payload.ID providers are listen in alphabetical order, just like in the userId documentation.