Fix rendering bug; Declare support for TCFv2 for Sharethrough bidder#2083
Merged
bretg merged 2 commits intoprebid:masterfrom Jun 24, 2020
sharethrough:md/sharethrough-docs
Merged
Fix rendering bug; Declare support for TCFv2 for Sharethrough bidder#2083bretg merged 2 commits intoprebid:masterfrom sharethrough:md/sharethrough-docs
bretg merged 2 commits intoprebid:masterfrom
sharethrough:md/sharethrough-docs
Conversation
- Sharethrough bid adapter supports TCFv2, this change updates Sharethrough documentation - See related merged PR prebid/Prebid.js#4723 Story: [#173455779](https://www.pivotaltracker.com/story/show/173455779)
- `dev-docs/bidders/selectmediavideo.md` does not close a markdown code block correctly - closing triple backticks are missing from the code block `\`\`\`` - syntax error is causing the section for Sharethrough at `http://localhost:8080/dev-docs/bidders/#sharethrough` not to appear - adding the closing backticks resolves the issue Story: [#173455779](https://www.pivotaltracker.com/story/show/173455779)
bretg
approved these changes
Jun 24, 2020
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Thanks for the PR to fix the example. Confirmed that pkey is already supported in the module
Contributor
|
I'm not sure this is going to fix the formatting -- will address it in a separate PR if it doesn't. |
Contributor
|
Did fix it. |
Contributor
Author
|
Thanks for the quick review @bretg ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Prebid team, please note that this PR combines an update and a bug fix.
Update
Bug fix
selectmediavideo.md). Incorrect markdown syntax is causing incorrect rendering, and as a result, the Sharethrough section in theBidderssection of the website is inaccessible.#sharethroughis not working yet other anchor tags work; then notice the syntax error addressed in commit https://github.com/sharethrough/prebid.github.io/commit/ecd703ff11487dbe5a67c53feefe957e1ddcc126 of this PR).Please let me know if you would like me to separate out the commits -- the broken documentation on prebid.org was flagged to us by a publisher.