Conversation
…nto prebidSDK_1_7
…nto floorsMultipleModels
dev-docs/modules/floors.md
Outdated
|
|
||
|
|
||
| *Example 1* | ||
| Model weights add up to 100 and are sampled at a 25%, 25%, 50% distrobution. Additionally, each model group has diffirent schema fields: |
made some minor grammatical edits
jeanstemp
left a comment
jeanstemp
left a comment
There was a problem hiding this comment.
I made some minor edits, but I also have one question on a sentence that occurs in a couple of places.
dev-docs/modules/floors.md
Outdated
| | enforcement.enforceJS | boolean | If set to true, the floors module will provide floors to bid adapters for bid request matched rules and suppress any bids not exceeding a matching floor. If set to false, the prebid floors module will still provide floors for bid adapters, there will be no floor enforcement.| true | | ||
| | enforcement.enforcePBS | boolean | If set to true, the Prebid.js floors module will signal to Prebid Server to pass floors to it’s bid adapters and enforce floors. If set to false, the pbjs should still pass matched bid request floor data to PBS, however no enforcement will take place. | false | | ||
| | enforcement.floorDeals | boolean | Enforce floors for deal bid requests. | false | | ||
| | enforcement.bidAdjustment | boolean | Adjust floors passed to Bid Aapters. If bid adjustment is passed to PBS and flag set is not set to false | true | |
There was a problem hiding this comment.
The second sentence here (If bid adjustment...) is incomplete. Do you know what it's supposed to be?
There was a problem hiding this comment.
I really don't like the language i selected. Don't know what i was thinking. This document is so large I cannot recall my thought process at the time. I would like to reword this, with some assistance by you to wordsmith.
If bidAdjustment is set to true, the Floors Module will adjust the applied floor per bidder by using bidAdjustment function if supplied. If set to false, floors will not be adjusted. Setting this flag to false may have unexpected consequence such as signaling a gross floor when expecting net or vice versa.
There was a problem hiding this comment.
Thanks for clarifying! Suggested rewording of the above:
"If true, the Floors Module will use the bidAdjustment function (if supplied) to adjust the floor per bidder. If false, floors will not be adjusted. Note: Setting this parameter to false may have unexpected results, such as signaling a gross floor when expecting net or vice versa."
What happens if they don't supply a bidAdjustment function?
There was a problem hiding this comment.
This is a per bidder setting the bidAdjustment. If the publisher does not supply a bidAdjustment function, then the Floors Module will do nothing to the bid. We can only adjust by what the bidAdjustment function provides.
There was a problem hiding this comment.
Okay, minor adjustment:
"If true, the Floors Module will use the bidAdjustment function to adjust the floor per bidder. If false (or no bidAdjustment function is provided), floors will not be adjusted. Note: Setting this parameter to false may have unexpected results, such as signaling a gross floor when expecting net or vice versa."
How does that sound?
There was a problem hiding this comment.
That looks good, thank you.
dev-docs/modules/floors.md
Outdated
| | enforcement.enforceJS | boolean | If set to true, the floors module will provide floors to bid adapters for bid request matched rules and suppress any bids not exceeding a matching floor. If set to false, the prebid floors module will still provide floors for bid adapters, but there will be no floor enforcement.| true | | ||
| | enforcement.enforcePBS | boolean | If set to true, the Prebid.js floors module will signal to Prebid Server to pass floors to it’s bid adapters and enforce floors. If set to false, Prebid.js should still pass matched bid request floor data to Prebid Server, however no enforcement will take place. | false | | ||
| | enforcement.floorDeals | boolean | Enforce floors for deal bid requests. | false | | ||
| | enforcement.bidAdjustment | boolean | Adjust floors passed to Bid Aapters. If bid adjustment is passed to Prebid Server and flag set is not set to false | true | |
There was a problem hiding this comment.
Same as above, incomplete sentence here.
There was a problem hiding this comment.
Read the above. I appreciate you stepping up to apply a second set of eyes and clear up ambiguous language as well as provide wordsmith.
3 participants
Adding documentation for schema version 2