Skip to content

TrueReach Bidder Document#2099

Merged
MartianTribe merged 1 commit intoprebid:masterfrom
mmprebid:tr-adapter
Jul 17, 2020
Merged

TrueReach Bidder Document#2099
MartianTribe merged 1 commit intoprebid:masterfrom
mmprebid:tr-adapter

Conversation

@mmprebid
Copy link
Contributor

This new bidder documentation PR is related to new bidder TrueReach PR.

---

### Note:
For more information, please visit us at: [TrueReach Ads](http://doc.truereach.co.in/docs/prebid/js-bidder-adapter.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landing page for this URL isn't very helpful. Are you sure this is the right URL? Also, it would be better if you provided a secure URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not really a landing page, it is just the "more info" regarding integration that will have our company's contact details and landing page(secure URL). We are already working on the content and UX of "more info" page, please check again.
If secure URL is not a requirement for this page, can we go with un-secure URL for now?

@bretg
Copy link
Contributor

bretg commented Jul 1, 2020

Please try to implement the secure URL. Not saying we won't allow non-secure, but it's not something you want to leave for long.

@mmprebid
Copy link
Contributor Author

mmprebid commented Jul 1, 2020

Sure, we will not leave it un-secure for long. But for now we would like to keep it this way for a few time.

@mmprebid
Copy link
Contributor Author

@bretg Kindly provide review progress status.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly encourage you to not forget to upgrade to HTTPS at some point, but will approve anyhow.

@bretg bretg added LGTM and removed question labels Jul 14, 2020
@bretg
Copy link
Contributor

bretg commented Jul 14, 2020

Doc approved. We don't merge the docs until the code is released.

@MartianTribe MartianTribe merged commit 9c0948a into prebid:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments