Skip to content

Medianet doc updates#2160

Merged
jeanstemp merged 3 commits intoprebid:masterfrom
media-net:medianet_video_doc_update
Jul 29, 2020
Merged

Medianet doc updates#2160
jeanstemp merged 3 commits intoprebid:masterfrom
media-net:medianet_video_doc_update

Conversation

@c3p-0
Copy link
Contributor

@c3p-0 c3p-0 commented Jul 24, 2020

  • Medianet video doc updates.
  • Added some examples.
  • Added tcf2_supported: true

@c3p-0
Copy link
Contributor Author

c3p-0 commented Jul 24, 2020

Corresponding MediaNet adapter video support PR: prebid/Prebid.js#5482

@Fawke
Copy link
Contributor

Fawke commented Jul 27, 2020

Hi @bretg,

I was reviewing the corresponding PR for Prebid.js, and according to the blogpost for Prebidv4.0, we now need adapter to pass video params under mediaTypes.video object instead of bidder.params. Is this something we are enforcing now, or is it for a future major release? I gathered that we are enforcing it from now onwards!

@Fawke Fawke requested a review from bretg July 27, 2020 03:49
@bretg
Copy link
Contributor

bretg commented Jul 27, 2020

@c3p-0 - @Fawke is right - video parameters must come from mediatypes.video. It's ok to accept them on BOTH mediatypes.video AND bidder params.

@c3p-0
Copy link
Contributor Author

c3p-0 commented Jul 28, 2020

Thanks @bretg , So no action is required from my side.

@Fawke
Copy link
Contributor

Fawke commented Jul 28, 2020

@c3p-0, I think you need to accept video params from either location. bidder.params (which you are currently doing now)or mediaTypes.video. It's encouraged that you do it from the latter. I don't know whether this'll require a docs change or not.

@c3p-0
Copy link
Contributor Author

c3p-0 commented Jul 29, 2020

As suggested by @Fawke we are consuming video from both bidder.params and mediaTypes.video and giving precedence to mediaTypes.video.
@bretg Please let me know If this PR is looking good or not.

@jeanstemp
Copy link
Contributor

@c3p-0 Bret is on vacation. It looks like you've mentioned support for mediaTypes.video and included it in your example. So I'm going to go ahead and merge this; if anyone thinks additional updates are required we can make them later.

@jeanstemp jeanstemp merged commit 3ee73c1 into prebid:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants