Skip to content

Instream AMP example#2175

Closed
shoys89 wants to merge 1 commit intoprebid:masterfrom
shoys89:master
Closed

Instream AMP example#2175
shoys89 wants to merge 1 commit intoprebid:masterfrom
shoys89:master

Conversation

@shoys89
Copy link
Contributor

@shoys89 shoys89 commented Jul 31, 2020

This PR includes a prebid.js video example using Akamai Adaptive Media Player (AMP)

@MartianTribe
Copy link
Collaborator

Hi

I created a separate branch on this site with your code and merged it into our staging site. The new PR is:

#2181

The link to the staging site is in that PR. The video player functions correctly but there seems to be an issue with the ads playing. This is not unique to your player, all of them are having problems. We just did a couple big releases and I have put in an issue for the devs to review and debug the samples.

If you can check out the staging site and confirm it looks fine to you (with the above exception) that'd be great. I'll merge it into master and close this PR. I tried adding you as a reviewer but it appears you haven't joined Prebid's Github. You should still be able to comment on the PR though.

Thanks

@shoys89
Copy link
Contributor Author

shoys89 commented Aug 4, 2020

Hi @MartianTribe
Thanks.
I took a look at the staging site and confirmed everything looks ok.

@bretg
Copy link
Contributor

bretg commented Aug 13, 2020

Your product name has an unfortunate collision with another more prominent definition of AMP. Please make sure wherever you refer to AMP that it's clear you mean Akamai's product and not Google's Accelerated Mobile Pages. Thanks.

@bretg bretg requested a review from MartianTribe August 13, 2020 19:46
@MartianTribe
Copy link
Collaborator

I recreated this example in another branch and it has been merged, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants