Merged
Conversation
Contributor
|
LGTM. |
mkendall07
reviewed
Apr 21, 2017
download.md
Outdated
| <div class="checkbox"> | ||
| <label> | ||
| <input type="checkbox" analyticscode="roxot" class="analytics-check-box"> Roxot | ||
| <input type="checkbox" analyticscode="roxot" class="analytics-check-box"> Prebid Analitics by Roxot |
Contributor
There was a problem hiding this comment.
There is a typo in analytics :)
Contributor
Author
|
@mkendall07 Thank you for noticing. Fixed. |
Contributor
Author
|
@mkendall07 |
Contributor
|
This PR LGTM. Still reviewing (and discussing) the other Roxot PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
Please rename "Roxot" analytics adapter to "Prebid Analytics by Roxot". It's the official name for our analytics product and we want to be consistent across different platforms. Otherwise, publishers might be confused when seeing the same product under different names.
Could you merge it to the master as soon as the 0.22.0 prebid.js is released?
Thanks in advance.