clarifying bidderSettings/setPriceGranularity message#232
Merged
rmloveland merged 1 commit intoprebid:masterfrom May 4, 2017
bretg:clarify-biddersetting-granularity
Merged
clarifying bidderSettings/setPriceGranularity message#232rmloveland merged 1 commit intoprebid:masterfrom bretg:clarify-biddersetting-granularity
rmloveland merged 1 commit intoprebid:masterfrom
bretg:clarify-biddersetting-granularity
Conversation
Contributor
|
Thanks for the clarification @bretg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tweaking the wording here based on a conversation with @mkendall07 from last week
I had formerly been under the impression that the existence of any bidderSetting invalidated the use of setPriceGranularity, but it's really the existence of adserverTargeting within bidderSettings.