[AD-963] Add documentation for JW Player RTD Provider#2427
Merged
bretg merged 7 commits intoprebid:masterfrom Oct 28, 2020
Merged
[AD-963] Add documentation for JW Player RTD Provider#2427bretg merged 7 commits intoprebid:masterfrom
bretg merged 7 commits intoprebid:masterfrom
Conversation
1 task
bretg
suggested changes
Oct 21, 2020
bretg
reviewed
Oct 21, 2020
3 tasks
Contributor
Author
|
@bretg I addressed your comments, could you please review ? Thanks |
bretg
suggested changes
Oct 28, 2020
karimMourra
commented
Oct 28, 2020
| ``` | ||
|
|
||
| 3) In order to prefetch targeting information for certain media, include the media IDs in the `jwplayerRtdProvider` var and set `waitForIt` to `true` before calling `setConfig`: | ||
| 3) In order to prefetch targeting information for certain media, include the media IDs in the `jwplayer` var and set `waitForIt` to `true` before calling `setConfig`: |
Contributor
Author
There was a problem hiding this comment.
i disagree with this change, there is no jwplayer var. I think this would be confusing to the reader.
var jwplayer = {...}; would be a jwplayer var. I'll address this
karimMourra
commented
Oct 28, 2020
Comment on lines
110
to
118
| fpd: { | ||
| context: { | ||
| data: { | ||
| jwTargeting: { | ||
| segments: ['123', '456'], | ||
| content: { | ||
| id: 'jw_abc123' | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is wrong, we are not adding the targeting information to fpd, we are adding it on the bid object. We read from adUnit.fpd and write to bid.
bretg
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for prebid/Prebid.js#5844