Merged
Conversation
This was referenced Nov 14, 2020
mansinahar
reviewed
Nov 25, 2020
Contributor
Author
|
@mansinahar @MartianTribe As the prebid.js adapter already merged to main repo, can docs be merged to? |
Collaborator
|
Hey, sorry I missed this. But you also support PBS and that PR has not yet been approved. Do you want to change this to PBS = false, merge the docs, then set PBS is true and add another PR linked to #1585? Once your PBS adapter is accepted then we can update the docs? Does that make sense? |
Contributor
Author
|
@MartianTribe Currently PBS adapter already approved by all reviewers, but not merged yet, I think it will be merged in few days , so lets merge the docs with adapter. |
SyntaxNode
reviewed
Jan 5, 2021
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.