pubGENIUS bidder: update doc to add video params#2539
Merged
jeanstemp merged 2 commits intoprebid:masterfrom Dec 11, 2020
Merged
pubGENIUS bidder: update doc to add video params#2539jeanstemp merged 2 commits intoprebid:masterfrom
jeanstemp merged 2 commits intoprebid:masterfrom
Conversation
2 tasks
bretg
approved these changes
Dec 3, 2020
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Will approve, but what's the use case for providing video params as an override to the AdUnit.mediaTypes.video params? We're trying to get away from bidder-specific params where possible.
Contributor
Author
Thanks for the feedback! I didn't know it. If that's where we're going, I'll remove mentioning the override here. In the implementation PR there was a feedback to add the overriding params to the .md doc. I guess I might misunderstand it somewhere. |
Contributor
Author
|
Fixed as per the comment. Let me know if there is any other feedbacks. |
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
* pubGENIUS bidder: update video doc * require properties in adUnit.mediaTypes.video
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kevinstubbs for team awareness