Updated Between adapter dev docs#2549
Conversation
|
Thanks @egsk for addressing the feedback. LGTM :) |
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Actually, there's an important problem here -- this file is shared by your prebid.js and prebid server adapters.
Prebid strongly recommends that PBJS and PBS adapters take the same set of parameters, so publishers can easily switch between client and server, but if that's not the case, it needs to be clear to publishers which params are supported and required for which.
I see from https://github.com/prebid/Prebid.js/blob/master/modules/betweenBidAdapter.md that your client adapters supports an 's' param which isn't in this doc.
Since your client- and server-params are so different, you might want to break them into different tables?
|
@bretg |
copied from original client-side adapter commit 8f623b4#diff-b224ab4090e3b286923b7eb808974fcb155f98dda399b7050270d28c7e6f55e4
|
You server team stomped on the client team's parameters. I fixed from GitHub history. |
* Updated Between adapter dev docs * Between adapter dev docs: review fix * Between adapter dev docs: review fix #2 * Added quotes to string params * Between adapter dev docs: review fix #3 * fixing PBJS adapter params copied from original client-side adapter commit prebid@8f623b4#diff-b224ab4090e3b286923b7eb808974fcb155f98dda399b7050270d28c7e6f55e4 Co-authored-by: Egor Skorokhodov <skorokhodov@betweenx.com> Co-authored-by: bretg <bgorsline@gmail.com>
3 participants
added missed parameters and update their description. see prebid/prebid-server#1587