GumGum: adds note that mediaType video is required for video products#2551
Merged
bretg merged 12 commits intoprebid:masterfrom Dec 4, 2020
Merged
GumGum: adds note that mediaType video is required for video products#2551bretg merged 12 commits intoprebid:masterfrom
bretg merged 12 commits intoprebid:masterfrom
Conversation
9 tasks
bretg
reviewed
Dec 4, 2020
|
|
||
|
|
||
| Please note that both video and in-video products require a mediaType of video. | ||
| All other products (in-screen, slot, native) should have a mediaType of banner. No newline at end of file |
Contributor
There was a problem hiding this comment.
FYI - Prebid doesn't recommend delivering native ads through 'mediaType.banner'. If this is necessary, then we will soon require that you set meta.mediaType="native" on the bidResponse object.
bretg
approved these changes
Dec 4, 2020
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
I'll go ahead and merge this, but please consider the comment about piggybacking native on the banner mediaType.
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
…prebid#2551) * specifies us privacy is supported * adds video support to gumgum md * adds support for tcf 2 * adds new bid param to gumgum.md * updates gumgum doc * notes required mediaType for video products
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related prebid.js PR: prebid/Prebid.js#6066