Merged
Conversation
Only bring in what we need to keep CSS size down
So that we can include it separately and still use it in webpack build pipeline
For styling and JS
Via browsersync Without this change I was having to wait for Jekyll to finish rebuilding the site in order to see CSS changes
bootstrap import stubbed till we can figure out just which bits we need and can limit the import to keep JS size down
Removing some unneeded CSS/JS dn prep work for new site fonts
Use the same nav struct for mobile view as well
Should see if we can trim this down at some point and not load _all_ of the utility classes
Also fix unbalanced tags and add comments to sort out unbalanced tag
So that we don’t have extra margin below sidebar when left nav is collapsed on mobile
Since the local compiled bootstrap uses features of JS that aren’t supported in IE11 and aren’t being “fixed” by babel in testing.
Switching from sizes in design comp to Minor Thirds ratio to have more difference in font size between the levels.
h5 isn’t used in the content area on the site but adding it here so that it’s available in the future if an h5 is added.
Required adding semi-bold italic font from Google for proper display in browsers.
Leaving italic on h5 since h5 is same size as body copy and leaving italic-semi-bold include to support h5 styling.
Make the overall page wider and the sidebar narrower, then give all that extra space to the content.
It didn’t in review/testing but this tweak will ensure it doesn’t in the future.
# Conflicts: # dev-docs/modules/userId.md
Revert CNAME to be correct for production site before opening a PR. This reverts commit 8c44d99.
So that PR for production site doesn’t block search indexing.
Had to move away from JS build process due to issues generating a cross-browser JS file.
Per request.
# Conflicts: # README.md # _assets/sass/components/_pb.scss # _layouts/home.html # assets/css/main-bundle.css # webpack.mix.js
bretg
approved these changes
Dec 10, 2020
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Checked this locally. Looks good. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated markup and styling for better display of Download page.