Conversation
|
Hi, can you please link this docs PR to your code PR. Thanks! |
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Please add the pbjs: true header or it won't appear in the dynamically-generated page
|
@bretg I'm confused, I don't see "pbjs: true" in any of the other files in dev-docs/bidders. If this is a requirement, why don't any of the other documentation files have it? |
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Thanks for adding pbjs: true. Maybe you forked the docs repo > 4 months ago? All of them have that header field now.
Noticed that you added 'inmarId' as a userId -- unless I'm misunderstanding something, this needs to be removed.
dev-docs/bidders/inmar.md
Outdated
|
|
||
| biddercode: inmar | ||
| usp_supported: true | ||
| userIds: inmarId, identityLink, liveIntentId, unifiedId, pubProvidedId |
There was a problem hiding this comment.
Please remove "inmarId" -- there's no user ID module for InMar on https://docs.prebid.org/dev-docs/modules/userId.html nor is there a PR open for a new one.
|
We will remove InmarID. I don't want to duplicate cards here, but we simply do not understand how the GetUserSyncs will result in our ability to get our own Cookie ID in bid requests. If we do not name any field in the bid request for a publisher to send us our UserID we don't understand how we'll ever get that sent to us. We can ideally resolve that in this ticket: prebid/Prebid.js#5674 |
|
thanks - this went out with 4.11, so merging now. |
* Add Inmar bidder adapter * Update Inmar bidder adapter documentation * Update Inmar bidder adapter documentation * Remove inmarId from userIds
4 participants
Inmar bidder adapter documentation