Merged
Conversation
10 tasks
bretg
suggested changes
Jan 15, 2021
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
As I noted over in the code PR, Prebid's goal is that bidders should not make publishers specify video parameters in each bidder-specific params area. video parameters should go be read by the adapter from mediatypes.video first.
It's ok if an adapter looks in both places, but the documentation needs to let publishers know that they can place these params up at the mediatypes level and not have to replicate them here.
bretg
approved these changes
Feb 12, 2021
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Very well, we'll merge this, but you're going to have to clean this up someday - probably with 5.0
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Feb 23, 2021
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.