Merged
Conversation
Only bring in what we need to keep CSS size down
So that we can include it separately and still use it in webpack build pipeline
For styling and JS
Via browsersync Without this change I was having to wait for Jekyll to finish rebuilding the site in order to see CSS changes
bootstrap import stubbed till we can figure out just which bits we need and can limit the import to keep JS size down
Removing some unneeded CSS/JS dn prep work for new site fonts
Use the same nav struct for mobile view as well
Should see if we can trim this down at some point and not load _all_ of the utility classes
Also fix unbalanced tags and add comments to sort out unbalanced tag
We will be styilng via native site CSS
For more readable customizations
Per feedback
Per feedback
To get updated CSS to be used.
So that we can edit it w/out battling with Jekyll/Liquid parsing and formatting.
For saner result display
This reverts commit a6b9e8e. These updates are not ready to launch yet - revert them so they’re not part of the PR for bidder updates
This reverts commit 23d00e5. These updates are not ready to launch yet - revert them so they’re not part of the PR for bidder updates
# Conflicts: # assets/css/main-bundle.css # dev-docs/bidders/adhese.md # dev-docs/bidders/adkernel.md # dev-docs/bidders/adkernelAdn.md # dev-docs/bidders/adot.md # dev-docs/bidders/adprime.md # dev-docs/bidders/beachfront.md # dev-docs/bidders/between.md # dev-docs/bidders/brightroll.md # dev-docs/bidders/colossus.md # dev-docs/bidders/decenterads.md # dev-docs/bidders/improvedigital.md # dev-docs/bidders/inmobi.md # dev-docs/bidders/kidoz.md # dev-docs/bidders/kubient.md # dev-docs/bidders/livewrapped.md # dev-docs/bidders/mobilefuse.md # dev-docs/bidders/readpeak.md # dev-docs/bidders/revcontent.md # dev-docs/bidders/richaudience.md # dev-docs/bidders/rtbhouse.md # dev-docs/bidders/smartrtb.md # dev-docs/bidders/sonobi.md # dev-docs/bidders/synacormedia.md # dev-docs/bidders/tappx.md # dev-docs/bidders/ucfunnel.md # dev-docs/bidders/vdoai.md # dev-docs/bidders/visx.md # download.md
Whenever bidders are added to the site they need to be assigned to a `list_group` from `dev-docs/bidders.md` via the individual bidder frontmatter. If a bidder isn’t assigned to a `list_group` then they won’t appear on the Bidders page. This script checks all bidders and lists those that aren’t assigned to a `list_group`. Exclude the script so it’s not included in the generated site.
Restore expected CNAME for production site. This reverts commit 0c0166c.
Allow indexing of production site. This reverts commit 543ea07.
Contributor
|
@bookwyrm - thanks, but I'm not real fond of the new 'list_group' header value. These values are set and maintained by hundreds of different companies, and they will certainly screw them up. It will end up adding a bunch of error-prone work on the part of the doc reviewers... we're going to have to A) remember to make sure it's there and B) keep a list of the valid values. Is there no way to automate this grouping another way? How about this: |
This is a better approach do it by parsing the title rather than relying on a value in the frontmatter
Make them sorted by title in a case-insensitive manner
Now that we are grouping by parsing title, we no longer need the list_group in the frontmatter.
Contributor
Author
|
Thanks, @bretg. This is a much better approach. |
bretg
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds doc search to the site via Algolia.
Restructures Bidders page to add autocomplete support and updated design that groups bidders by name.
Includes a helper script (
find-ungrouped-bidders.sh) to verify that all Bidders have been assigned to alist_groupfor proper display on the Bidders page.