Outbrain prebid server support and new params#2796
Closed
rokostik wants to merge 4 commits intoprebid:masterfrom
Closed
Outbrain prebid server support and new params#2796rokostik wants to merge 4 commits intoprebid:masterfrom
rokostik wants to merge 4 commits intoprebid:masterfrom
Conversation
This was referenced Mar 24, 2021
Contributor
|
@rokostik - please fix the merge conflicts |
…upport_and_new_params
Contributor
Author
|
Hey @bretg since both the referenced PRs have been merged and the conflicts resolved could this PR be merged too? |
bretg
approved these changes
Apr 12, 2021
bretg
suggested changes
Apr 12, 2021
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Just noticed that you're using ## here instead of ###. Please start your heading at level 3.
Contributor
We don't merge docs PRs until the code has been released. This doc request will be merged once PBJS 4.35 is released, normally on a Weds. But please either fix the heading level or give me permission to do so in your fork. |
bretg
approved these changes
Apr 12, 2021
Contributor
Author
|
I'm closing this PR, since #2847 was already merged and contains all commits from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
This PR adds documentation about our prebid server adapter and two new bidding params:
bcatandbadv