Conversation
dev-docs/modules/fpd.md
Outdated
| | viewport width | device.w | Hunts for window.innerWidth, window.document.documentElement.clientWidth, window.document.body.clientWidth | | ||
| | viewport height | device.w | Hunts for window.innerHeight, window.document.documentElement.clientHeight, window.document.body.clientHeight | | ||
| | meta keywords | site.keywords | Looks for a meta tag with name=keywords | | ||
|
|
There was a problem hiding this comment.
do we imagine future enrichments would happen in new submodules or in the current submodule behind config? For example parsing timezone into country or copying the floc from eid to device object or video ad unit enrichment
Could affect how this is worded.
There was a problem hiding this comment.
My take is case-by-case. If the enrichment is cheap, we can stick it in here. If it's expensive (code size and processing) it should live in a new module.
What wording would it affect?
There was a problem hiding this comment.
Largely just that this is "the" enrichment submodule as opposed to language suggesting first of several
|
I need to update this to reflect the split into sub-modules |
|
This seems to suggest the split is into two different modules instead of two submodules of one module |
|
discussed in taxonomy committee, this looks good as is and we'll handle docs / name changes as new submodules come |
2 participants
Docs PR for prebid/Prebid.js#6452