Conversation
Update server side params to reflect supported params for DMX
bretg
suggested changes
Apr 29, 2021
dev-docs/bidders/dmx.md
Outdated
| | publisher_id | required | Represent boost MemberId from DistrictM UI | 'member1' | string | | ||
| | memberid | required | Represent boost MemberId from DistrictM UI *legacy replace by publisher_id| 'member1' | string | | ||
| | tagid | required | Represent the placement ID from DistrictM or your own | '123abc' | string | | ||
| | dmxid | required | Represent the placement ID from DistrictM or your own *legacy replace by tagid | '123abc' | string | |
Contributor
There was a problem hiding this comment.
Don't understand this one... how is dmxid different than tagid? The comment seems to indicate that dmxid is "legacy, replaced by tagid", but it's still marked as "required". Is that correct?
Contributor
|
@stevealliance , please see comment above. |
Contributor
Author
|
@bretg update these values to be optional |
bretg
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update server side params to reflect supported params for DMX