Conversant adapter include mediaTypes.video#2968
Merged
bretg merged 2 commits intoprebid:masterfrom Jun 3, 2021
Merged
Conversation
… of video parameters
jeanstemp
suggested changes
May 24, 2021
dev-docs/bidders/conversant.md
Outdated
| | `tag_id` | optional | Identifies specific ad placement. | `'cnvr-test-tag'` | `string` | | ||
| | `position` | optional | Ad position on screen. See details below. | `1` | `integer` | | ||
| | `white_label_url`| optional | Override the destination URL the request is sent to. | `'https://mydomain.com/hbendpoint'` | `string` | | ||
| | `pubcid_name` | optional | Name of the pub common id. Conversant adapter can read the id directly if the UserID module is absent. Default is _pubcid.| `_pubcid` | `string` | |
Contributor
There was a problem hiding this comment.
Please put single quotes around the string value.
dev-docs/bidders/conversant.md
Outdated
|
|
||
| | Name | Scope | Description | Example | Type | | ||
| |---------------|-----------------------------|---------------------------------------------------------------------------------------------------------------------------|-------------------|------------------| | ||
| | `position` | optional | Ad position on screen. See details below. Only supported in in bids.params. | `1` | `integer` | |
… of video parameters - review changes
Contributor
Author
|
Thanks @jeanstemp. File updated. |
bretg
approved these changes
Jun 3, 2021
Contributor
|
@pycnvr - is this docs PR associated with a code change or ready to merge? |
jeanstemp
approved these changes
Jun 3, 2021
9 tasks
Contributor
Author
|
@bretg Yes. The code change has been merged. I've just added the link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Conversant doc to say that video params could include mediaType.video.