Skip to content

tappx - Update adapter docs#3004

Merged
bretg merged 1 commit intoprebid:masterfrom
prebidtappx:hotfix/tappx-update-devdoc
Jun 4, 2021
Merged

tappx - Update adapter docs#3004
bretg merged 1 commit intoprebid:masterfrom
prebidtappx:hotfix/tappx-update-devdoc

Conversation

@prebidtappx
Copy link
Contributor

We have updated our dev-doc to correct data that was not correct.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I'd like to discuss the colon in front of your brand. Can I get you to re-think that? Not fond of the sorting implications and the arms race it might spawn to get sorted to the top (or bottom) of the bidder list.

@prebidtappx
Copy link
Contributor Author

Hello @bretg
The colon is included in our name and whenever possible we add it (you can see it at https://www.tappx.com/, https: //iabeurope.eu/vendor-list / ...). When I reviewed this document, I realized that it wasn't included and so I corrected it.
If possible we would prefer to include it. I understand that the only impact would be a matter of order in the listings, right?

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out locally. Jekyll ignores the colon for sorting, so all good.

@bretg bretg merged commit 8fba83b into prebid:master Jun 4, 2021
@prebidtappx
Copy link
Contributor Author

prebidtappx commented Jun 4, 2021

Thank you very much @bretg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments