Skip to content

Comments

Add Checkbox in Download Page for FLoC ID System#3005

Merged
bretg merged 1 commit intoprebid:masterfrom
ian-lr:floc-download
Jun 7, 2021
Merged

Add Checkbox in Download Page for FLoC ID System#3005
bretg merged 1 commit intoprebid:masterfrom
ian-lr:floc-download

Conversation

@ian-lr
Copy link
Contributor

@ian-lr ian-lr commented Jun 2, 2021

Per prebid/Prebid.js#6521 (comment) adding a checkbox to download the FLoC module.

Tested locally and confirmed download includes floc module.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian, but I'm not going to approve putting this on the download page until someone writes a floc section in https://docs.prebid.org/dev-docs/modules/userId.html

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 3, 2021

Agreed; I saw this commit and was hoping it was the impetus we needed to get floc documented

@ian-lr
Copy link
Contributor Author

ian-lr commented Jun 3, 2021

That's fair. @jdwieland8282 who from PMC should run with this?

@jdwieland8282
Copy link
Member

had a little time this afternoon to knock that out.

FLoC docs PR: #3006

@bretg bretg merged commit 8f03b2f into prebid:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants