Skip to content

Comments

akamaiDAPIdSystem doc Update#3058

Merged
jeanstemp merged 1 commit intoprebid:masterfrom
amishra11j:MPT-417
Jul 1, 2021
Merged

akamaiDAPIdSystem doc Update#3058
jeanstemp merged 1 commit intoprebid:masterfrom
amishra11j:MPT-417

Conversation

@amishra11j
Copy link
Contributor

@amishra11j amishra11j commented Jun 23, 2021

Documentation for a new userId submodule, akamaiDAPId

@amishra11j amishra11j mentioned this pull request Jun 23, 2021
Merged
1 task
bretg
bretg suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a row to the bid adapter implementation table towards the bottom of the file so adapters know how to integrate with you.

smenzer
smenzer previously requested changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests to the userId_spec.js file, otherwise this LGTM

@smenzer smenzer dismissed their stale review June 24, 2021 10:01

wrong pr

@amishra11j
Copy link
Contributor Author

amishra11j commented Jun 25, 2021

I had a document change requested for my Prebid.js PR so incorporated the same here as well

smenzer
smenzer approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the implementation in pbjs

@amishra11j
Copy link
Contributor Author

amishra11j commented Jun 28, 2021

Hi @bretg , I have added a row to the bid adapter implementation table and updated the PR.

@jeanstemp jeanstemp merged commit f1323b6 into prebid:master Jul 1, 2021
@amishra11j amishra11j deleted the MPT-417 branch July 3, 2021 21:09
@TheMediaGrid
Copy link
Contributor

TheMediaGrid commented Jul 17, 2021 •
edited
Loading

@bretg QQ: why isn't Akamai present on the prebid download page though this PR is merged?

@bretg
Copy link
Contributor

bretg commented Jul 19, 2021

ID adapters don't automatically show up on the download page. They have to be added in a PR.

Generally I don't do this for ID adapters -- they may have their own reasons for not wanting to be on the download page.

In this case, several people have asked me about it, so I'll go ahead and do it. Heads-up @amishra11j

@bretg
Copy link
Contributor

bretg commented Jul 19, 2021

Done in #3129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@bretg bretg bretg requested changes

@smenzer smenzer smenzer approved these changes

@jeanstemp jeanstemp jeanstemp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs work not merged yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amishra11j @TheMediaGrid @bretg @smenzer @jeanstemp