Minor changes in the /master/dev-docs/bidders/pixfuture.md#3108
Closed
pixfuture-media wants to merge 10 commits intoprebid:masterfrom
Closed
Minor changes in the /master/dev-docs/bidders/pixfuture.md#3108pixfuture-media wants to merge 10 commits intoprebid:masterfrom
pixfuture-media wants to merge 10 commits intoprebid:masterfrom
Conversation
MartianTribe
requested changes
Jul 15, 2021
Collaborator
MartianTribe
left a comment
MartianTribe
left a comment
There was a problem hiding this comment.
Hi, minor typo and grammatical error:
The
pix_idparameter should be anstringr<<
Should be: The pix_id parameter should be a String
I would have fixed it but I couldn't edit the file.
10 tasks
Contributor
Author
|
The minor typo and grammatical error: In the pix_id description has been removed space |
bretg
suggested changes
Jul 15, 2021
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Description still says "should be an stringr"
Contributor
Author
|
Misspelling 'stringr' changed to 'string' |
Contributor
Author
|
We fixed that misspelling. |
bretg
added a commit
that referenced
this pull request
Jul 16, 2021
replaces #3108 In the future, allowing us to modify your fork would make fixing conflicts like this easier.
bretg
added a commit
that referenced
this pull request
Jul 16, 2021
replaces #3108 In the future, allowing us to modify your fork would make fixing conflicts like this easier.
Contributor
|
Fixed with #3117 -- that was easier than trying to fix your fork without write perms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two parameters pbjs and pbs has been changed in the /master/dev-docs/bidders/pixfuture.md