Skip to content

Comments

Add GPID to documentation#3141

Closed
epechuzal wants to merge 1 commit intoprebid:masterfrom
sharethrough:ep/PGE-178206245/gpid-support
Closed

Add GPID to documentation#3141
epechuzal wants to merge 1 commit intoprebid:masterfrom
sharethrough:ep/PGE-178206245/gpid-support

Conversation

@epechuzal
Copy link
Contributor

This is in reference to our addition of GPID support in

| `bcat` | optional | Array of blocked IAB Categories | `['IAB1-2', 'IAB1-3']` | `string[]` |
| `badv` | optional | Array of blocked Advertisers by their domains | `['ford.com', 'pepsi.com']` | `string[]` |
| `pkey` | required | The placement key | `'DfFKxpkRGPMS7A9f71CquBgZ'` | `string` |
| `data` | optional | Object containing additional first party data. See [Data Object](#data-object) for details. |`data: { pbadlot: 'string' }` | `object` |
Copy link
Contributor

@bretg bretg Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here (pbadlot), but more importantly, it's not ok for you to make pbadslot a bidder-specific param.

You need to be reading this data from the AdUnit.ortb2Imp.ext.data.pbadslot for PBJS or imp[]ext.data.pbadslot for PBS. See https://docs.prebid.org/features/pbAdSlot.html

You can copy that location to wherever your endpoint requires, but you cannot make publishers specify the pbadslot in a bidder-specific way.

Copy link
Contributor Author

@epechuzal epechuzal Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg this is actually how we implemented those features, but I was told in prebid/prebid-server#1925 that I had to update documentation.

Is this not the case?

@epechuzal
Copy link
Contributor Author

epechuzal commented Aug 10, 2021

Going to close this as it sounds like there is actually no need to add documentation for GPID support.

@bretg let me know if this is not the case and if there is something I should be doing here

@epechuzal epechuzal closed this Aug 10, 2021
@epechuzal epechuzal deleted the ep/PGE-178206245/gpid-support branch August 10, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants