Prebid 6 legacy code deploy example#3362
Merged
bretg merged 7 commits intoprebid:masterfrom Nov 10, 2021
Merged
Conversation
Contributor
|
In general, the formatting looks right. My only question would be whether this example needs to sit so high in the examples list in the navbar? |
Collaborator
Author
|
It does not; also the fiddle should be correct now |
Contributor
|
Minor typo in the fiddle... 'annswer'. Is it intended that the 'self-invoked wrapper' script is commented out? What is prebid4ie.js? |
bretg
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the right js fiddle yet, please lmk if I am putting this in the correct place / modifying the correct files.